Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to create RepositoryServer CR using kanctl command line #2032

Merged
merged 41 commits into from
May 29, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Apr 24, 2023

Change Overview

Add functionality to create RepositoryServer CR using kanctl command line tool.
Like Profile, RepositoryServer could also be created using kanctl create repository-server

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Testing

1) Build kanctl

go build -o kanctl cmd/kanctl/main.go

2) Create Repository Server using kanctl

  • Without --wait flag
./kanctl create repository-server \
--prefix /repo-controller/ \
--user kanisteruser --user-access-secret repository-server-user-access \
--kopia-repository-user kanisteradmin --admin-user-access-secret repository-admin-user \
--tls-secret repository-server-tls-cert --kopia-repository-password-secret repo-pass \
--location-secret s3-location --location-creds-secret s3-creds --namespace kanister

repository-server 'kopia-repo-server-nzc5f' created
  • With --wait flag (Repository Server gets ready)
./kanctl create repository-server \
--prefix /repo-controller/ \
--user kanisteruser --user-access-secret repository-server-user-access \
--kopia-repository-user kanisteradmin --admin-user-access-secret repository-admin-user \
--tls-secret repository-server-tls-cert --kopia-repository-password-secret repo-pass \
--location-secret s3-location --location-creds-secret s3-creds --namespace kanister --wait

Waiting for the kopia repository server CR to be in ready state...
repositoryservers.cr.kanister.io/kopia-repo-server-2hdlz created
  • With --wait flag (Repository Server doesn't gets ready)
./kanctl create repository-server \
--prefix /repo-controller/ \
--user kanisteruser --user-access-secret repository-server-user-access \
--kopia-repository-user kanisteradmin --admin-user-access-secret repository-admin-user \
--tls-secret repository-server-tls-cert --kopia-repository-password-secret repo-pass \
--location-secret s3-location --location-creds-secret s3-creds --namespace kanister --wait

repositoryservers.cr.kanister.io/kopia-repo-server-ch2vx created
Waiting for the kopia repository server CR to be in ready state...
Error: Repository Server is not ready.
Current Status: ServerStopped
Reason: Failed to connect to Kopia repository: Failed to connect to the backup repository: Access Denied: Failed to exec command in pod: command terminated with exit code 1
: Context done while polling: context deadline exceeded

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Apr 24, 2023
@r4rajat r4rajat changed the title Add functionality to create repository-server using kanctl command line tool Add functionality to create RepositoryServer CR using kanctl command line Apr 24, 2023
r4rajat and others added 2 commits May 11, 2023 22:31
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
r4rajat and others added 3 commits May 12, 2023 15:35
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comments

pkg/kanctl/repositoryserver.go Show resolved Hide resolved
pkg/kanctl/repositoryserver.go Outdated Show resolved Hide resolved
pkg/kanctl/repositoryserver.go Outdated Show resolved Hide resolved
pkg/kanctl/repositoryserver.go Outdated Show resolved Hide resolved
pkg/kanctl/repositoryserver.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required May 12, 2023
r4rajat and others added 6 commits May 15, 2023 23:29
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat requested a review from kale-amruta May 16, 2023 16:46
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
docs/tooling.rst Outdated Show resolved Hide resolved
r4rajat and others added 3 commits May 25, 2023 16:51
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat requested a review from kale-amruta May 25, 2023 13:34
r4rajat and others added 4 commits May 25, 2023 21:14
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat added the kueue label May 26, 2023
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat removed the kueue label May 27, 2023
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat added kueue and removed kueue labels May 27, 2023
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kanister automation moved this from Review Required to Reviewer approved May 29, 2023
@r4rajat r4rajat added the kueue label May 29, 2023
@mergify mergify bot merged commit fd4624a into master May 29, 2023
3 checks passed
Kanister automation moved this from Reviewer approved to Done May 29, 2023
@mergify mergify bot deleted the repository-server-create-kanctl branch May 29, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants