Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github workflow to build and push MongoDB Atlas tools image #2038

Merged
merged 4 commits into from
May 9, 2023
Merged

Add github workflow to build and push MongoDB Atlas tools image #2038

merged 4 commits into from
May 9, 2023

Conversation

shahpratikr
Copy link
Contributor

Change Overview

This PR adds automation to create mongodb-atlas image to ghcr.io registry.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Apr 28, 2023
@viveksinghggits
Copy link
Contributor

@shahpratikr
We were not planning to build the image and publish it using kanister right? Did we change that?

@shahpratikr shahpratikr force-pushed the pratik/mongodb-atlas-support branch from 6282a7b to 7bc117f Compare May 2, 2023 07:30
@shahpratikr
Copy link
Contributor Author

@shahpratikr We were not planning to build the image and publish it using kanister right? Did we change that?

We discussed that for E2E tests, we will need to build image. hence added this change to build atlas image as well

@shahpratikr shahpratikr force-pushed the pratik/mongodb-atlas-support branch from 3c625e8 to 936fb34 Compare May 2, 2023 07:37
Base automatically changed from pratik/mongodb-atlas-support to master May 2, 2023 08:22
@shahpratikr shahpratikr changed the title Add mongodb-atlas image to ghcr.io registry Add github workflow to build and push MongoDB Atlas tools image May 8, 2023
viveksinghggits
viveksinghggits reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. We can merge this once we decide that we really want this in E2E.

.github/workflows/atlas-image-build.yaml Outdated Show resolved Hide resolved
.github/workflows/atlas-image-build.yaml Show resolved Hide resolved
@shahpratikr shahpratikr added kueue and removed kueue labels May 9, 2023
@julio-lopez julio-lopez removed the kueue label May 9, 2023
@julio-lopez julio-lopez enabled auto-merge (squash) May 9, 2023 16:16
@julio-lopez julio-lopez merged commit b9eee33 into master May 9, 2023
Kanister automation moved this from In Progress to Done May 9, 2023
@julio-lopez julio-lopez deleted the pratik/add_atlas_image branch May 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
None yet
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shahpratikr @viveksinghggits @julio-lopez