skip TestSnapshotCopy for GPD block storage #2045
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The test
TestSnapshotCopy
gives nil pointer exception since*dstSnapshot
is not initialized for GPD provider. Hence passing it tos.provider.SnapshotCopy
would fail the testEven if we initialize
dstSnapshot
asdstSnapshot = &blockstorage.Snapshot{}
, the test would still fail sinceSnapshotCopy
is not implemented for GPD providerThe test
TestSnapshotCopy
passes for AWS provider but fails for GPD provider.This PR is to skip the test for GPD provider
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan