Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Long Startup Time for Kopia Repository Server #2048

Merged
merged 5 commits into from
May 10, 2023
Merged

Fix Long Startup Time for Kopia Repository Server #2048

merged 5 commits into from
May 10, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented May 4, 2023 •
edited

Change Overview

Fix Long Startup Time for Kopia Repository Server

  • As of now we're checking for Kopia Repository Server status before starting the server till the commands runs successfully or exits due to timeout.
  • Instead of running till the command runs successfully or exits due to timeout, we're just checking once before starting server, if command runs successfully, we won't start server, else we'll start the server.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@r4rajat
Fix Long Startup for Kopia Repository Server
1ba33f9 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister May 4, 2023
@r4rajat
Change Name of Functions
23bb50f 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
kale-amruta
kale-amruta requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout the comments

Kanister automation moved this from In Progress to Review Required May 5, 2023
@r4rajat
Resolving Suggestions
11d78c2 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Reuse Redundant Code
3be9782 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@mergify mergify bot mentioned this pull request May 5, 2023
Closed
10 tasks
@r4rajat r4rajat added the kueue label May 6, 2023
kale-amruta
kale-amruta approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kanister automation moved this from Review Required to Reviewer approved May 8, 2023
@mergify mergify bot merged commit 9ce4426 into master May 10, 2023
Kanister automation moved this from Reviewer approved to Done May 10, 2023
@mergify mergify bot deleted the fix-long-repo-server-startup branch May 10, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@kale-amruta kale-amruta kale-amruta approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r4rajat @viveksinghggits @kale-amruta @PrasadG193