Move kopia storage consts to a secrets package #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
kale-amruta
changed the title
kale-amruta
force-pushed
the
refactoringKopiaConstants
branch
from
d2a3d67
to
63e856b
Compare
kale-amruta
force-pushed
the
refactoringKopiaConstants
branch
from
63e856b
to
4a1fa5a
Compare
kale-amruta
changed the title
There was a problem hiding this comment.
LGTM, but this PR does not seem to handle refactor for other constants. Would there be a separate PR for these? Respective comment: #1940 (comment)
kale-amruta
force-pushed
the
refactoringKopiaConstants
branch
from
f3157b1
to
a8ee0de
Compare
PrasadG193
reviewed
May 26, 2023
kale-amruta
force-pushed
the
refactoringKopiaConstants
branch
from
4e3bc64
to
5b63e96
Compare
ankitjain235
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Move the kopia location secret consts to
secretspackage so that they can be reused. We cannot use the consts from storage package in secrets since it creates cyclic dependency. Hence moving it to secrets package. This PR would be the base PR for validation of kopia repository server secrets PR - #1940Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan