Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connecting to kopia repository using GCP credentials in repository server controller #2061

Merged
merged 4 commits into from
May 23, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented May 12, 2023

Change Overview

Connecting to kopia repository using GCP location credentials was not working correctly. The creds file for GCP was being written to a repo server pod before the pod was created. This PR moves the code to write the gcp location credentials to file after the repo server pod is created

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@kale-amruta kale-amruta changed the title fix gcp workflow for kopia repository fix connecting to kopia repository using GCP credentials in repository server controller May 12, 2023
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@mergify mergify bot merged commit 1cf25e5 into master May 23, 2023
@mergify mergify bot deleted the fixGCPWorkflow branch May 23, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants