Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Source Location in cp command for repo-server-build target #2081

Merged
merged 1 commit into from
May 31, 2023

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented May 31, 2023

Change Overview

With goreleaser v1.8.0, ARCH targets are appended with _v1 to _v4 suffixes. Made changes in repo-server-build target to handle this.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
make repo-server-build
make[1]: Entering directory 'kanister'
  • build succeeded after 4s
make[1]: Leaving directory 'kanister'

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister May 31, 2023
@akankshakumari393 akankshakumari393 marked this pull request as ready for review May 31, 2023 13:32
Kanister automation moved this from In Progress to Reviewer approved May 31, 2023
@mergify mergify bot merged commit 38b348a into master May 31, 2023
16 checks passed
Kanister automation moved this from Reviewer approved to Done May 31, 2023
@mergify mergify bot deleted the fix-repo-srver-build-target branch May 31, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants