Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FoundationDB example to build image manually #2089

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Refactor FoundationDB example to build image manually #2089

merged 7 commits into from
Jun 8, 2023

Commits on Jun 6, 2023

  1. Remove foundationdb image from getting published on every merge and a… 

    …lso during release

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
    @akankshakumari393
    akankshakumari393 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f0b5dcb View commit details
    Browse the repository at this point in the history

  2. Add instructions in README to create foundationdb image manually 

    Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
    @akankshakumari393
    akankshakumari393 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2d67435 View commit details
    Browse the repository at this point in the history

  3. Add command to install kando in foundationDB DockerFile 

    Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
    @akankshakumari393
    akankshakumari393 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    a4d1e01 View commit details
    Browse the repository at this point in the history

  4. Update examples/foundationdb/README.md 

    Co-authored-by: Prasad Ghangal <prasad.ghangal@gmail.com>
    @akankshakumari393 @PrasadG193
    akankshakumari393 and PrasadG193 authored Jun 6, 2023
    Configuration menu
    Copy the full SHA
    1453a91 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
    @akankshakumari393 @pavannd1
    akankshakumari393 and pavannd1 authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    81d47b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Apply Prasad's suggestions 

    Co-authored-by: Prasad Ghangal <prasad.ghangal@gmail.com>
    @pavannd1 @PrasadG193
    pavannd1 and PrasadG193 authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    3d171f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 2088

    @mergify
    mergify[bot] authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c61a216 View commit details
    Browse the repository at this point in the history