-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all CI commands inside the build container #209
Conversation
helm/kanister-operator/values.yaml
Outdated
@@ -2,8 +2,8 @@ | |||
# This is a YAML-formatted file. | |||
# Declare variables to be passed into your templates. | |||
image: | |||
repository: kanisterio/controller | |||
tag: 0.20.0 | |||
repository: tdmanville/kanister-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a local testing change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is indeed - though we do need to change this to kanisterio/controller
This should shave 1:30 off the CI time:
|
Shaved 6 minutes off CI |
helm/kanister-operator/values.yaml
Outdated
@@ -2,7 +2,7 @@ | |||
# This is a YAML-formatted file. | |||
# Declare variables to be passed into your templates. | |||
image: | |||
repository: kanisterio/controller | |||
repository: kanisterio/kanister-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we renaming the controller image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because then we have to change
repository: kanisterio/controller |
and ALL other references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a mismatch in the goreleaser file. I'll change that instead of this.
Change Overview
Pull request type
Please check the type of change your PR introduces: