Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all CI commands inside the build container #209

Merged
merged 9 commits into from
Aug 15, 2019
Merged

Run all CI commands inside the build container #209

merged 9 commits into from
Aug 15, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 15, 2019

Change Overview

  • Performance improvements
    • Use simple travis VM since all commands are containerized
    • Use https://docs.travis-ci.com/user/caching/
      • go mod source files
      • go build cache
    • Parallel jobs for docs and go tests
    • Add binaries to build image
      • kind, docker, jq
  • travis config simplificiations
    • uses start/stop-kind instead of directly invoking local_kube.sh
  • Makefile updates
    • Use tabs consistently
    • add go-mod-download
    • add release-snapshot

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

@@ -2,8 +2,8 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.
image:
repository: kanisterio/controller
tag: 0.20.0
repository: tdmanville/kanister-controller
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a local testing change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is indeed - though we do need to change this to kanisterio/controller

@tdmanv tdmanv changed the title Add several CI improvements Run all CI commands inside the build container Aug 15, 2019
@tdmanv
Copy link
Contributor Author

tdmanv commented Aug 15, 2019

This should shave 1:30 off the CI time:

fetching PR.209/cache-linux-trusty-ba046e48339afca65649ce5a9c8e3f5d41c611db015d9d7f89f9e5899e4bb612--go-1.12.x.tgz
found cache
0.00s6.03sadding /home/travis/gopath/src/github.com/kanisterio/kanister/.go/pkg/mod to cache
creating directory /home/travis/gopath/src/github.com/kanisterio/kanister/.go/pkg/mod

@tdmanv tdmanv requested a review from depohmel August 15, 2019 18:56
@tdmanv
Copy link
Contributor Author

tdmanv commented Aug 15, 2019

Shaved 6 minutes off CI

@@ -2,7 +2,7 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.
image:
repository: kanisterio/controller
repository: kanisterio/kanister-controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we renaming the controller image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because then we have to change

repository: kanisterio/controller

and ALL other references

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mismatch in the goreleaser file. I'll change that instead of this.

@tdmanv tdmanv merged commit 77cbb4b into master Aug 15, 2019
@tdmanv tdmanv deleted the fix-build branch August 15, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants