Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check while fetching secrets in repository server CR #2102

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

kale-amruta
Copy link
Contributor

Change Overview

This PR adds a nil check for secrets fields in the repository server CR

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jun 13, 2023
@kale-amruta kale-amruta changed the title add nil check for secrets fields in repository server CR Add nil check while fetching secrets in repository server CR Jun 13, 2023
Kanister automation moved this from In Progress to Reviewer approved Jun 13, 2023
@mergify mergify bot merged commit b7a4e02 into master Jun 13, 2023
15 checks passed
Kanister automation moved this from Reviewer approved to Done Jun 13, 2023
@mergify mergify bot deleted the AddSecretsCheck branch June 13, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants