-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deletion of the pod created by blueprint without namespace #2106
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think it would be good to have unit test coverage for both cases (with and without namespace).
|
Change Overview
This PR fixes pod which aren't deleted if create by blueprints without namespace
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
run blueprint without namespace:
ensure that kanister-job was deleted