Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to customize kopia cmd log level #2107

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

redgoat650
Copy link
Contributor

@redgoat650 redgoat650 commented Jun 13, 2023

Change Overview

Add the option to run kopia commands with arbitrary log level values. All default log level settings remain unchanged if no option is provided.

This change adds the ability to choose the log level when generating kopia commands by providing a LogLevel option in the CommandArgs structure.

I agree to the DCO for all the commits in this PR.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

# cd pkg/kopia/command
# go test
OK: 18 passed
PASS
ok      github.com/kanisterio/kanister/pkg/kopia/command        0.045s
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Add the option to run kopia commands with arbitrary log level values.
All default log level settings remain unchanged if no option is
provided.
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@redgoat650 redgoat650 requested a review from pavannd1 June 13, 2023 19:53
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Jun 13, 2023
@mergify mergify bot merged commit 0b3f846 into master Jun 13, 2023
@mergify mergify bot deleted the param-kopia-log-level branch June 13, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants