Update docs with new changes; Add info about new kanister func #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tdmanv
approved these changes
Aug 16, 2019
SupriyaKasten
changed the title
|
@tdmanv my bad! |
pavannd1
requested changes
Aug 16, 2019
| @@ -149,6 +152,7 @@ as follows: | |||
| ConfigMaps map[string]ObjectReference `json:"configMaps"` | |||
| Secrets map[string]ObjectReference `json:"secrets"` | |||
| Profile *ObjectReference `json:"profile"` | |||
| Options map[string]string `json:"options"` | |||
There was a problem hiding this comment.
[minor] Please check formatting here. Looks like italics is enabled.
There was a problem hiding this comment.
@SupriyaKasten I think this is because of *ObjectReference. * enabled italics. Let's move your change above Profile for now.
pavannd1
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Update docs with; add info about new kanister func
Pull request type
Please check the type of change your PR introduces: