Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding container image vulnerability scanning (Grype) GitHub Action #2113

Merged
merged 9 commits into from
Jul 10, 2023

Conversation

mellon-collie
Copy link
Contributor

@mellon-collie mellon-collie commented Jun 15, 2023

Change Overview

This PR creates a new GitHub action workflow to run the grype vulnerability scanning tool on all of Kanister's advertised container images. This GitHub action workflow has not been integrated into any of Kanister's CI/CD workflows yet, and needs to be manually triggered.

Summary of changes:

New GitHub Action Workflow yaml with path: .github/workflows/grype-vulnerability-scanner.yaml that reads from the single source of truth of all valid images in build/valid_images.json.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

The GitHub action will be manually triggered using workflow_dispatch - but for validation on a non-master branch, a GitHub CLI based trigger test has been added: https://github.com/kanisterio/kanister/actions/runs/5492665300

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jun 15, 2023
scripts/valid_images.json Outdated Show resolved Hide resolved
@mellon-collie mellon-collie force-pushed the grype-vulnerability-scanner-github-action branch from a5870f0 to 3e402fa Compare June 29, 2023 14:56
@mellon-collie
Copy link
Contributor Author

mellon-collie commented Jul 7, 2023

Link to latest GitHub action run: https://github.com/kanisterio/kanister/actions/runs/5492665300

Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Kanister automation moved this from In Progress to Reviewer approved Jul 10, 2023
@mellon-collie mellon-collie removed the request for review from viveksinghggits July 10, 2023 17:52
@pavannd1 pavannd1 merged commit faee7f3 into master Jul 10, 2023
17 of 26 checks passed
@pavannd1 pavannd1 deleted the grype-vulnerability-scanner-github-action branch July 10, 2023 18:22
Kanister automation moved this from Reviewer approved to Done Jul 10, 2023
kale-amruta pushed a commit that referenced this pull request Jul 11, 2023
…2113)

Grype vulnerability scanning github action

fix tests
mellon-collie added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants