Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields for kopia cache, log and config directory in repository server CR #2144

Merged
merged 72 commits into from
Aug 16, 2023
Merged

Add fields for kopia cache, log and config directory in repository server CR #2144

merged 72 commits into from
Aug 16, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Jun 28, 2023 •
edited

Change Overview

This PR adds optional fields for kopia cache,log and config directory in the repository server CR. If these fields are not provided, default values for these fields would be used which connecting to kopia repository

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

kale-amruta and others added 30 commits April 12, 2023 14:55
@kale-amruta
add unit tests for repository server controller
fa5b584
@kale-amruta
test
c6bca5d
@kale-amruta
add prerequisites for tests
14bf4fb
@kale-amruta
Merge branch 'master' into AddUnitTests
2981b9f
@kale-amruta
add server ready test
43ad855
@kale-amruta
remove unwanted changes
97b5078
@kale-amruta
fix lint issues
7438cf7
@kale-amruta
automate creation of repo server CRD
7b086d8
@kale-amruta
address review comments
b284a95
@kale-amruta
add symbolic link
db72931
@kale-amruta
address comments
c0b184d
@kale-amruta
Merge branch 'master' into AddUnitTests
f30be02
@kale-amruta
Merge branch 'CreateCRDs' into AddUnitTests
58da9bc
@kale-amruta
remove custom resource
00a880c
@kale-amruta
renaming cli to kubecli
0606bfb
@kale-amruta
add more tests
400b187
@kale-amruta
fix lint issue
42ecfba
@kale-amruta
resolve conflicts
84c9a60
@kale-amruta
Merge branch 'master' into AddUnitTests
0ebf579
@r4rajat
Merge branch 'master' into AddUnitTests
c5b4b82
@r4rajat
Add tests for Immutability
a052242 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Fix naming conventions
d20b0bf 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge branch 'master' into AddUnitTests
81b8120
@r4rajat
Update variables
3018da5 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge branch 'master' into AddUnitTests
82a299d
@kale-amruta
Merge branch 'master' into AddUnitTests
6bc97bd
@kale-amruta
add tests related to secrets
ca158e0
@kale-amruta
add secrets configuration for testutils
074102f
@kale-amruta
add base suite for repository server controller
ac3f85d
@kale-amruta
Merge branch 'master' into baseUnitTestSuite
a3f43dc
@kale-amruta kale-amruta changed the base branch from master to AddUnitTests June 28, 2023 07:19
ankitjain235
ankitjain235 reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider adding a common object in CRD under which all these configurable values, and new ones that could come up be added?

pkg/apis/cr/v1alpha1/repositoryserver_types.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/repository.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/repository.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/repository.go Outdated Show resolved Hide resolved
pkg/customresource/repositoryserver.yaml Outdated Show resolved Hide resolved
@kale-amruta kale-amruta force-pushed the AddUnitTests branch 2 times, most recently from 649f29c to 172ee2c Compare July 11, 2023 11:24
Base automatically changed from AddUnitTests to master July 13, 2023 08:18
ankitjain235
ankitjain235 reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, looks good otherwise.

pkg/apis/cr/v1alpha1/repositoryserver_types.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/utils.go Outdated Show resolved Hide resolved
pkg/customresource/repositoryserver.yaml Outdated Show resolved Hide resolved
ankitjain235
ankitjain235 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Jul 31, 2023
@mergify mergify bot merged commit 7663904 into master Aug 16, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Aug 16, 2023
@mergify mergify bot deleted the honorMissingFields branch August 16, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kale-amruta @viveksinghggits @ankitjain235 @r4rajat