Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use claimName field in the filestore location secret for repository server controller #2146

Merged
merged 114 commits into from
Jul 25, 2023

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Jun 28, 2023

Change Overview

If filestore location storage is used as repository in repository server controller , claimName field in the location secret is not honoured. This field should be used to mount the pvc volume on repository server pod as a kopia repository. This PR fixes the issue by adding pvc as volumes on the repository server pod

Pull request type

Please check the type of change your PR introduces:

  • [] 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate out unrelated changes here? Looks good to me otherwise.

pkg/controllers/repositoryserver/utils.go Outdated Show resolved Hide resolved
pkg/testutil/testutil.go Outdated Show resolved Hide resolved
@kale-amruta kale-amruta changed the base branch from AddUnitTests to repositoryServerUnitTestsChange July 12, 2023 12:25
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/controllers/repositoryserver/utils.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/utils.go Outdated Show resolved Hide resolved
Base automatically changed from repositoryServerUnitTestsChange to master July 24, 2023 09:54
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some minor suggestions. Can be merged once addressed.

@mergify mergify bot merged commit d2f2442 into master Jul 25, 2023
14 checks passed
@mergify mergify bot deleted the fixfileStoreLocation branch July 25, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing mount when using kopia filestore repository
5 participants