-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use claimName field in the filestore location secret for repository server controller #2146
Conversation
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we separate out unrelated changes here? Looks good to me otherwise.
if podName and serviceName are not set even after the polling time exceeds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some minor suggestions. Can be merged once addressed.
89a3d81
to
a3070b1
Compare
Change Overview
If filestore location storage is used as repository in repository server controller , claimName field in the location secret is not honoured. This field should be used to mount the pvc volume on repository server pod as a
kopia repository
. This PR fixes the issue by adding pvc as volumes on the repository server podPull request type
Please check the type of change your PR introduces:
Issues
Test Plan