Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Refactor RepositoryServer controller"" #2154

Merged
merged 11 commits into from
Jul 25, 2023

Conversation

akankshakumari393
Copy link
Contributor

Reverts #2150

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 4, 2023
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393 akankshakumari393 marked this pull request as ready for review July 4, 2023 09:08
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a minor suggestion

pkg/controllers/repositoryserver/handler.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Jul 20, 2023
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@mergify mergify bot merged commit f876a47 into master Jul 25, 2023
15 checks passed
Kanister automation moved this from Reviewer approved to Done Jul 25, 2023
@mergify mergify bot deleted the revert-2150-revert-2136-refactor_repositoryserver branch July 25, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants