Use a file to specify the chronicle artifact prefix #217

tdmanv · 2019-08-20T00:53:14Z

Change Overview

Pull request type

Please check the type of change your PR introduces:

Issues

Test Plan

/go/src/github.com/kanisterio/kanister # go run -v ./cmd/kando/main.go chronicle push
Error: requires at least 1 arg(s), only received 0
Usage:
  kando chronicle push <command> [flags]

Flags:
  -s, --artifact-path string   Specify a file that contains an object store suffix (optional)
  -e, --env-dir string         Get environment variables from a envdir style directory(optional)
  -f, --frequency duration     The Frequency to push to object storage  (default 1m0s)
  -h, --help                   help for push
  -p, --profile-path string    Path to a Profile as a JSON string (required)

Global Flags:
  -v, --verbosity string   Log level (debug, info, warn, error, fatal, panic) (default "warning")

ERRO[0000] requires at least 1 arg(s), only received 0
exit status 1

Manual
Unit test
E2E

pavannd1 · 2019-08-21T00:05:23Z

pkg/kando/chronicle_push.go

@@ -30,8 +30,9 @@ func newChroniclePushCommand() *cobra.Command {
 	}
 	cmd.PersistentFlags().StringVarP(&params.ProfilePath, profilePathFlagName, "p", "", "Path to a Profile as a JSON string (required)")
 	cmd.MarkPersistentFlagRequired(profilePathFlagName)
-	cmd.PersistentFlags().StringVarP(&params.ArtifactPath, artifactPathFlagName, "s", "", "Specify a path suffix (optional)")
-	cmd.PersistentFlags().StringVarP(&params.EnvDir, envDirFlagName, "e", "", "Get environment variables from a (optional)")
+	cmd.PersistentFlags().StringVarP(&params.ArtifactFile, artifactPathFlagName, "s", "", "Specify a file that contains an object store suffix (optional)")


[minor] Remove optional

pkg/kando/chronicle_push.go

Use a file to specify the chronicle artifact prefix

9a4edf2

tdmanv requested a review from pavannd1 August 20, 2019 01:06

pavannd1 approved these changes Aug 21, 2019

View reviewed changes

tdmanv commented Aug 21, 2019

View reviewed changes

pkg/kando/chronicle_push.go Outdated Show resolved Hide resolved

Remove optional from flag description

f11f18d

tdmanv merged commit 809a5d0 into master Aug 21, 2019

tdmanv deleted the chron-art-file branch August 21, 2019 00:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a file to specify the chronicle artifact prefix #217

Use a file to specify the chronicle artifact prefix #217

tdmanv commented Aug 20, 2019

pavannd1 Aug 21, 2019

Use a file to specify the chronicle artifact prefix #217

Use a file to specify the chronicle artifact prefix #217

Conversation

tdmanv commented Aug 20, 2019

Change Overview

Pull request type

Issues

Test Plan

pavannd1 Aug 21, 2019

Choose a reason for hiding this comment