Return empty snapshot ID if any fatal error happened during the snapshot creation #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
TimonOmsk
requested review from
pavannd1,
viveksinghggits,
aaron-kasten,
e-sumin and
AlekseyBlokhin
pavannd1
reviewed
Jul 13, 2023
mergify
bot
deleted the
keu/dgolushko/fail_if_error_kopia_snapshot_create
branch
mellon-collie
pushed a commit
that referenced
this pull request
Jul 20, 2023
…hot creation (#2174) * Return empty snapshot in case if any fatal error happened during the snapshot creation * Unit for numFailed field * Print output to error * Return empty snapshot id * [nit] error message change --------- Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Small update to not to return partially created snapshots in case if any fatal error happened during the snapshot creation.
We cannot rely on a partial created snapshot.
Pull request type
Please check the type of change your PR introduces:
Test Plan