-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Networking/v1 as default group version in ingress manager #2175
Conversation
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for the future: Not sure if we still need the IngressManager
. We could probably use NetworkingV1
directly everywhere.
Nit: Should we remove |
Merging this now. Let's follow-up on the two comments soon. |
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Change Overview
This PR removes the Discovery APIs from ingress manager.
Now it uses networking v1 as default group version to manager ingress resources.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan