Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add unit tests for kopia repository server controller(PR #2)" #2178

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Revert "Add unit tests for kopia repository server controller(PR #2)" #2178

merged 1 commit into from
Jul 14, 2023

Conversation

PrasadG193
Copy link
Contributor

Reverts #1997
The tests are failing in CI. Please raise the PR again with a fix.

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 14, 2023
Kanister automation moved this from In Progress to Reviewer approved Jul 14, 2023
kale-amruta
kale-amruta approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PrasadG193 PrasadG193 merged commit 5d16f29 into master Jul 14, 2023
14 of 15 checks passed
Kanister automation moved this from Reviewer approved to Done Jul 14, 2023
@PrasadG193 PrasadG193 deleted the revert-1997-AddUnitTests branch July 14, 2023 12:55
kale-amruta added a commit that referenced this pull request Jul 17, 2023
@kale-amruta
Revert "Revert "Add unit tests for kopia repository server controller…
f9c407a 
…(PR #2) (#1997)" (#2178)"

This reverts commit 5d16f29.
@kale-amruta kale-amruta mentioned this pull request Jul 17, 2023
Merged
PrasadG193 pushed a commit that referenced this pull request Jul 19, 2023
@kale-amruta
Revert "Revert "Add unit tests for kopia repository server controller…
2494994 
…(PR #2)"" (#2180)

* Revert "Revert "Add unit tests for kopia repository server controller(PR #2) (#1997)" (#2178)"

This reverts commit 5d16f29.

* skip immuatability test for k8s version < 1.25

* check error is not nil for discovery client

* fix minor and major version variable names
mellon-collie pushed a commit that referenced this pull request Jul 20, 2023
@PrasadG193 @mellon-collie
Revert "Add unit tests for kopia repository server controller(PR #2) (#…
b059921 
…1997)" (#2178)

This reverts commit 6b1ceaa.
mabhi pushed a commit that referenced this pull request Jul 24, 2023
@kale-amruta @mabhi
Revert "Revert "Add unit tests for kopia repository server controller…
fc44dd9 
…(PR #2)"" (#2180)

* Revert "Revert "Add unit tests for kopia repository server controller(PR #2) (#1997)" (#2178)"

This reverts commit 5d16f29.

* skip immuatability test for k8s version < 1.25

* check error is not nil for discovery client

* fix minor and major version variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@kale-amruta kale-amruta kale-amruta approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PrasadG193 @viveksinghggits @kale-amruta