Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Repository Server condition check from ServerReady to Ready #2184

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Remove Repository Server condition check from ServerReady to Ready #2184

merged 1 commit into from
Jul 18, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Jul 18, 2023 •
edited

Change Overview

Due to Recent Changes in Repository Server Status Fields, While creating Actionsets with RepositoryServer reference, we were getting error even when RepositoryServer is in Ready state

$ ./kanctl create actionset --action backup --namespace kanister --blueprint backupdate-bp --deployment time-logger/time-logger --repository-server=kanister/kopia-repo-server-1

Please make sure that Repository Server CR 'kopia-repo-server-1' is in Ready State: Repository Server Not Ready
Error: resource verification failed

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@r4rajat
Remove Repository Server condition check from ServerReady to Ready
7b041d3 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 18, 2023
kale-amruta
kale-amruta approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kanister automation moved this from In Progress to Reviewer approved Jul 18, 2023
@r4rajat r4rajat added the kueue label Jul 18, 2023
@mergify mergify bot merged commit 27b3004 into master Jul 18, 2023
16 checks passed
Kanister automation moved this from Reviewer approved to Done Jul 18, 2023
@mergify mergify bot deleted the refactor-kanctl-command-line branch July 18, 2023 08:08
mellon-collie pushed a commit that referenced this pull request Jul 20, 2023
@r4rajat @mellon-collie
Remove Repository Server condition check from ServerReady to Ready (#…
2a56b95 
…2184)

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@kale-amruta kale-amruta kale-amruta approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees

@viveksinghggits viveksinghggits

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Getting Error While Creating Actionset with RepositoryServer Reference
3 participants
@r4rajat @viveksinghggits @kale-amruta