Removed the dependency on the operator kit #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshiomkarj
force-pushed
the
feature/remove-operator-kit
branch
from
11bc081
to
9ec83ec
Compare
|
Locally verified that CRDs are getting created. |
joshiomkarj
force-pushed
the
feature/remove-operator-kit
branch
from
9ec83ec
to
eb1b92e
Compare
|
Updated the PR to include license attribution to rook operator-kit. |
Added the license attribution for rook operator-kit in the files
joshiomkarj
force-pushed
the
feature/remove-operator-kit
branch
from
5dd02b9
to
16368a3
Compare
|
Looks good to me @joshiomkarj, will let @tdmanv approve it! |
tdmanv
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Contains code changes to remove the dependency from the operator kit
Pull request type
Please check the type of change your PR introduces:
Test Plan