Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(test): use testdata directory in tests #2202

Merged
merged 3 commits into from
Jul 20, 2023
Merged

cleanup(test): use testdata directory in tests #2202

merged 3 commits into from
Jul 20, 2023

Conversation

julio-lopez
Copy link
Contributor

@julio-lopez julio-lopez commented Jul 19, 2023 •
edited

Change Overview

Renames mock_data directory to testdata.

The testdata directory is both idiomatic and special in Go.

"The go tool will ignore a directory named testdata, making it available to hold ancillary data needed by the tests."

Ref: https://pkg.go.dev/cmd/go/internal/test

Pull request type

  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🤖 Test

Test Plan

  • ⚡ Unit test => in CI

#2114

@julio-lopez
cleanup(test): use testdata directory in tests
2dac64c 
The `testdata` directory is both idiomatic and special in Go.

> "The go tool will ignore a directory named "testdata", making
> it available to hold ancillary data needed by the tests."

Ref: https://pkg.go.dev/cmd/go/internal/test
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 19, 2023
pavannd1
pavannd1 reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let @mellon-collie +2 this.

mellon-collie
mellon-collie approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@mellon-collie mellon-collie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Jul 19, 2023
@julio-lopez julio-lopez enabled auto-merge (squash) July 19, 2023 23:23
@julio-lopez julio-lopez merged commit 704e0f0 into master Jul 20, 2023
12 of 14 checks passed
Kanister automation moved this from Reviewer approved to Done Jul 20, 2023
@julio-lopez julio-lopez deleted the testdata branch July 20, 2023 00:29
mabhi pushed a commit that referenced this pull request Jul 24, 2023
@julio-lopez @mabhi
cleanup(test): use testdata directory in tests (#2202)
a72ca82 
The `testdata` directory is both idiomatic and special in Go.

> "The go tool will ignore a directory named "testdata", making
> it available to hold ancillary data needed by the tests."

Ref: https://pkg.go.dev/cmd/go/internal/test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 left review comments

@mellon-collie mellon-collie mellon-collie approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julio-lopez @pavannd1 @mellon-collie