Remove unnecessary "kind" check in SecretRef #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkamra
force-pushed
the
remove_redundant_secretkind_check
branch
from
3329b9c
to
f49e65b
Compare
The ActionSet schema allows specifying secret refs under the "secrets" key. This commit removes the requirement that the user specify a `Kind` in the reference because that information is not required.
vkamra
force-pushed
the
remove_redundant_secretkind_check
branch
from
f49e65b
to
4b4059a
Compare
vkamra
commented
Aug 22, 2019
| @@ -12,7 +12,7 @@ import ( | |||
| "github.com/Masterminds/sprig" | |||
| . "gopkg.in/check.v1" | |||
| appsv1 "k8s.io/api/apps/v1" | |||
| "k8s.io/api/core/v1" | |||
| v1 "k8s.io/api/core/v1" | |||
There was a problem hiding this comment.
Annoying - but goimports is adding this - golang/go#28428
tdmanv
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The ActionSet schema allows specifying secret refs under
the "secrets" key.
This commit removes the requirement that the user specify
a
Kindin the reference because that information is notrequired.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan