Fix flaky respository server controller unit test

[kale-amruta]

Change Overview

The repository server CR state changes to Pending when next reconcilation executes, so that the process starts again. Hence whenever the CR state is changed to Failed a reconcilation is run and the status of the CR is changed to Pending. In the unit tests, after waitOnRepositoryServerState is called if we receive a Failed state, we return to the calling function. After that we get the latest repository Server CR object using kubecli.GET function. Meanwhile if the reconcilation is run, the repository server CR's status is changed to Pending. Hence the tests fail with following error:

repositoryserver_controller_test.go:377: 
        error:
          values are not equal
        got:
          "Pending"
        want:
          "Failed"
        stack:

This PR fixes the flakyness by returning the status field's value at the moment when its changed to Failed rather than depending on the next kubecli.GET call

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes #issue-number

Test Plan

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

Test output:

https://gist.github.com/kale-amruta/ade024a88ba9b982bed4f79d9b3efea8

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.