Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Duplicate Functions and Tests from kando package #2234

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Refactor Duplicate Functions and Tests from kando package #2234

merged 5 commits into from
Sep 27, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Aug 1, 2023 •
edited

Change Overview

Refactor Duplicate Functions and Tests from kando package as the Tests and Functions have been moved to datamover package after merging PR #1951

  • Removed location_test.go, kando_test.go
  • Removed duplicate functions like locationPull, locationPush and locationDelete
  • Moved helper function targetWriter to chronicle_pull.go

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@r4rajat
Remove test files from kando package
14ea6e0 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
- Remove Unused Functions
ce11733 
- Refactored helper function

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 1, 2023
@r4rajat r4rajat assigned r4rajat and PrasadG193 and unassigned r4rajat Aug 2, 2023
Kanister automation moved this from In Progress to Reviewer approved Aug 29, 2023
@r4rajat r4rajat added the kueue label Sep 27, 2023
@mergify mergify bot merged commit 410853d into master Sep 27, 2023
15 checks passed
Kanister automation moved this from Reviewer approved to Done Sep 27, 2023
@mergify mergify bot deleted the refactor-unused-functions-tests branch September 27, 2023 13:37
leuyentran pushed a commit that referenced this pull request Oct 18, 2023
@r4rajat
Refactor Duplicate Functions and Tests from kando package (#2234)
93981a3 
* Remove test files from kando package

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>

* - Remove Unused Functions
- Refactored helper function

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>

---------

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees

@PrasadG193 PrasadG193

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r4rajat @PrasadG193 @viveksinghggits