Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gocritic and gocyclo linters #2236

Merged
merged 8 commits into from
Dec 4, 2023

Merge branch 'master' into enable-linters-1

90bb397
Select commit
Loading
Failed to load commit list.
Merged

Enable gocritic and gocyclo linters #2236

Merge branch 'master' into enable-linters-1
90bb397
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Dec 4, 2023 in 0s

The pull request embarked with master (c07784b) is mergeable

Required conditions for merge:

  • all of:
    • #approved-reviews-by>=1
    • check-success=build (controller)
    • check-success=build (kanctl)
    • check-success=build (kando)
    • check-success=docs
    • check-success=gomod
    • check-success=lint
    • check-success=test (helm-test)
    • check-success=test (integration-test)
    • check-success=test (test)
    • label!="hold off merging"
    • label=kueue
  • all of [📃 From pull request rule Automatic merge]:
    • -draft [:pushpin: queue requirement]
    • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
    • all of:
      • #approved-reviews-by>=1
      • base=master
      • check-success=build (controller)
      • check-success=build (kanctl)
      • check-success=build (kando)
      • check-success=docs
      • check-success=gomod
      • check-success=lint
      • check-success=test (helm-test)
      • check-success=test (integration-test)
      • check-success=test (test)
      • label!="hold off merging"
      • label=kueue
    • any of [:twisted_rightwards_arrows: queue conditions]:
      • all of [:pushpin: queue conditions of queue default]:
        • any of [🛡 GitHub branch protection]:
          • check-success=Summary
          • check-neutral=Summary
          • check-skipped=Summary
        • any of [🛡 GitHub branch protection]:
          • check-success=gomod
          • check-neutral=gomod
          • check-skipped=gomod
        • any of [🛡 GitHub branch protection]:
          • check-success=lint
          • check-neutral=lint
          • check-skipped=lint
        • any of [🛡 GitHub branch protection]:
          • check-success=test (test)
          • check-neutral=test (test)
          • check-skipped=test (test)
        • any of [🛡 GitHub branch protection]:
          • check-success=test (helm-test)
          • check-neutral=test (helm-test)
          • check-skipped=test (helm-test)
        • any of [🛡 GitHub branch protection]:
          • check-success=test (integration-test)
          • check-neutral=test (integration-test)
          • check-skipped=test (integration-test)
        • any of [🛡 GitHub branch protection]:
          • check-success=docs
          • check-neutral=docs
          • check-skipped=docs
        • any of [🛡 GitHub branch protection]:
          • check-success=dependency-review
          • check-neutral=dependency-review
          • check-skipped=dependency-review
        • any of [🛡 GitHub branch protection]:
          • check-success=build (controller)
          • check-neutral=build (controller)
          • check-skipped=build (controller)
        • any of [🛡 GitHub branch protection]:
          • check-success=build (kanctl)
          • check-neutral=build (kanctl)
          • check-skipped=build (kanctl)
        • any of [🛡 GitHub branch protection]:
          • check-success=build (kando)
          • check-neutral=build (kando)
          • check-skipped=build (kando)
  • any of [🛡 GitHub branch protection]:
    • check-success=Summary
    • check-neutral=Summary
    • check-skipped=Summary
  • any of [🛡 GitHub branch protection]:
    • check-success=gomod
    • check-neutral=gomod
    • check-skipped=gomod
  • any of [🛡 GitHub branch protection]:
    • check-success=lint
    • check-neutral=lint
    • check-skipped=lint
  • any of [🛡 GitHub branch protection]:
    • check-success=test (test)
    • check-neutral=test (test)
    • check-skipped=test (test)
  • any of [🛡 GitHub branch protection]:
    • check-success=test (helm-test)
    • check-neutral=test (helm-test)
    • check-skipped=test (helm-test)
  • any of [🛡 GitHub branch protection]:
    • check-success=test (integration-test)
    • check-neutral=test (integration-test)
    • check-skipped=test (integration-test)
  • any of [🛡 GitHub branch protection]:
    • check-success=docs
    • check-neutral=docs
    • check-skipped=docs
  • any of [🛡 GitHub branch protection]:
    • check-success=dependency-review
    • check-neutral=dependency-review
    • check-skipped=dependency-review
  • any of [🛡 GitHub branch protection]:
    • check-success=build (controller)
    • check-neutral=build (controller)
    • check-skipped=build (controller)
  • any of [🛡 GitHub branch protection]:
    • check-success=build (kanctl)
    • check-neutral=build (kanctl)
    • check-skipped=build (kanctl)
  • any of [🛡 GitHub branch protection]:
    • check-success=build (kando)
    • check-neutral=build (kando)
    • check-skipped=build (kando)

Check-runs and statuses of the embarked pull request #2236:

releasedetails
build (controller)details
build (kanctl)details
build (kando)details
dependency-reviewdetails
docsdetails
gomoddetails
lintdetails
test (helm-test)details
test (integration-test)details
test (test)details
View more details on Mergify