-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the data type for metadata and content fields in v1alpha1.CacheSizeSettings #2237
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
c524f05
to
0fc0def
Compare
ede7edf
to
c7dbf5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comment, looks good otherwise.
…he repository server CR
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
8559b19
to
6b2b63c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Change Overview
Currently the Metadata and Content fields in CacheSizeSettings have string as a data type whereas kopia CLI accepts the values for these fields as integer.
It would be better if the CRD accepts the fields in Integer format since that would reduce the number of conversions required in the GO code
This PR changes the field types to
*int
formetadata
andcontent
fieldsPull request type
Please check the type of change your PR introduces:
Issues
Test Plan