Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix echo/base64 examples commands #224

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Fix echo/base64 examples commands #224

merged 2 commits into from
Aug 22, 2019

Conversation

gouglhupf
Copy link
Contributor

Change Overview

The commands to create base64 encoded strings for manual secret creation are wrong. The echo command prints a new line by default. This alters the actual value to be encoded.

To keep this from happening you can add the parameter -n or use the command printf.

echo "YOUR_KEY" | base64 returns WU9VUl9LRVkK and
echo -n "YOUR_KEY" | base64 returns WU9VUl9LRVk=.

The Kubernetes documentation also suggests the echo -n command. https://kubernetes.io/docs/concepts/configuration/secret/#creating-a-secret-manually

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

Issues

I have not created an issue.

Test Plan

For testing see command above.

  • Manual
  • Unit test
  • E2E

Copy link
Contributor

@tdmanv tdmanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you for the PR!

@tdmanv tdmanv merged commit b88d1b9 into kanisterio:master Aug 22, 2019
@gouglhupf gouglhupf deleted the fix-echo-examples branch August 22, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants