Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The commands to create base64 encoded strings for manual secret creation are wrong. The
echo
command prints a new line by default. This alters the actual value to be encoded.To keep this from happening you can add the parameter
-n
or use the commandprintf
.echo "YOUR_KEY" | base64
returnsWU9VUl9LRVkK
andecho -n "YOUR_KEY" | base64
returnsWU9VUl9LRVk=
.The Kubernetes documentation also suggests the
echo -n
command. https://kubernetes.io/docs/concepts/configuration/secret/#creating-a-secret-manuallyPull request type
Please check the type of change your PR introduces:
Issues
I have not created an issue.
Test Plan
For testing see command above.