-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable misspell, nestif golang linter #2240
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
41261a0
Enable gocyclo linter
ankitjain235 118bc8a
Enable gocritic linter
ankitjain235 9fe8ef0
Fix typo for linters-settings, fix gocyclo lint failures
ankitjain235 88f1097
Add lll linter
ankitjain235 cf599c9
Add nakedret linter
ankitjain235 4c91b50
Enable dupl linter
ankitjain235 54d1d5e
Enable exportloopref linter
ankitjain235 ad04108
Enable importas linter
ankitjain235 953121f
Enable misspell linter
ankitjain235 605f039
Enable nestif linter
ankitjain235 31e838f
Fix minor typo
ankitjain235 b4cf462
Merge master, resolve conflicts
ankitjain235 2f1bbe4
Update new lint misses, add TODO for lint disables
ankitjain235 ef78a07
Merge master, resolve conflicts
ankitjain235 62b8959
Merge master, resolve conflicts
ankitjain235 41933d9
Merge master, resolve conflicts
ankitjain235 9c3b9a1
Merge master, resolve conflicts
ankitjain235 44a39cb
Fix misspell lint failure
ankitjain235 a874943
Merge master, resolve conflicts
ankitjain235 612154b
Apply linter to new changes
ankitjain235 0007316
Merge master, resolve conflicts
ankitjain235 7a3945a
Fix merge issues
ankitjain235 75b4f9d
Merge parent, resolve conflicts
ankitjain235 bc30421
Merge parent, resolve conflicts
ankitjain235 6695929
Merge master, resolve conflicts
ankitjain235 8c38dc0
Merge branch 'enable-linters-2' into enable-linters-3
ankitjain235 d522754
Add missing newlint
ankitjain235 32f0cae
Merge parent, resolve conflicts
ankitjain235 fded60e
Add explanation for ignoring dupl linter
ankitjain235 3f68dab
Merge branch 'enable-linters-2' into enable-linters-3
ankitjain235 08e0240
Merge branch 'enable-linters-3' into enable-linters-4
ankitjain235 e30c1ce
Remove unnecessary comment
ankitjain235 5b6234c
Merge branch 'master' into enable-linters-2
ankitjain235 5e97339
Address review comments
ankitjain235 da05972
Address review comments - move args
ankitjain235 a8795b2
Merge branch 'master' into enable-linters-2
ankitjain235 95d4b08
Merge parent, resolve conflicts
ankitjain235 7e7f3bf
Merge parent, resolve conflicts
ankitjain235 446c437
Temporarily disable depguard linter, lint fix
ankitjain235 8727b06
Merge branch 'enable-linters-2' into enable-linters-3
ankitjain235 a435fdf
Merge branch 'enable-linters-3' into enable-linters-4
ankitjain235 74180ac
Fix merge error
ankitjain235 722b3f8
Merge master, resolve conflicts
ankitjain235 b7c7b3a
Fix error message in test
ankitjain235 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine to enable
misspell
in test file if doesn't require much changesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does require changes. Enabling these linters for tests would need a lot of extra work. I'll create a separate issue for the same?