Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2241] Fix path to valid_images.json #2242

Merged
merged 1 commit into from
Aug 5, 2023
Merged

[2241] Fix path to valid_images.json #2242

merged 1 commit into from
Aug 5, 2023

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Aug 5, 2023

Change Overview

The push_images.sh script is executed from the root directory. Requires build/valid_images.json to be able to get the image list. This has been failing silently for a while now.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
    Changed docker push to echo to print the list
    Before:
./build/push_images.sh
cat: valid_images.json: No such file or directory
./build/push_images.sh: line 31: IMAGES[@]: unbound variable

After:

./build/push_images.sh
ghcr.io/kanisterio/mysql-sidecar:v9.99.9-dev
ghcr.io/kanisterio/kafka-adobe-s3-sink-connector:v9.99.9-dev
ghcr.io/kanisterio/postgres-kanister-tools:v9.99.9-dev
ghcr.io/kanisterio/postgresql:v9.99.9-dev
ghcr.io/kanisterio/cassandra:v9.99.9-dev
ghcr.io/kanisterio/kanister-kubectl-1.18:v9.99.9-dev
ghcr.io/kanisterio/mongodb:v9.99.9-dev
ghcr.io/kanisterio/es-sidecar:v9.99.9-dev
ghcr.io/kanisterio/controller:v9.99.9-dev
ghcr.io/kanisterio/kanister-tools:v9.99.9-dev
ghcr.io/kanisterio/kafka-adobe-s3-source-connector:v9.99.9-dev
ghcr.io/kanisterio/mssql-tools:v9.99.9-dev
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Kanister automation moved this from In Progress to Reviewer approved Aug 5, 2023
@mergify mergify bot merged commit 15e2aae into master Aug 5, 2023
16 checks passed
Kanister automation moved this from Reviewer approved to Done Aug 5, 2023
@mergify mergify bot deleted the fix_push_images branch August 5, 2023 10:26
@mellon-collie
Copy link
Contributor

@pavannd1 Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] CI failed to push Kanister Container Images to GHCR
3 participants