Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chron pull test to use the artifact string #225

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 22, 2019

Change Overview

Fixes broken test

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

Test Plan

Before

FAIL: chronicle_test.go:41: ChronicleSuite.TestPushPull

chronicle_test.go:64:
    c.Assert(err, IsNil)
... value *errors.withStack = getItem, getting the object: InvalidParameter: 1 validation error(s) found.
- minimum field size of 1, GetObjectInput.Key.
 ("getItem, getting the object: InvalidParameter: 1 validation error(s) found.\n- minimum field size of 1, GetObjectInput.Key.\n")

OOPS: 2 passed, 1 FAILED
--- FAIL: Test (3.65s)
FAIL

After

/go/src/github.com/kanisterio/kanister/pkg/chronicle # go test -v -check.v -check.f TestPushPull
=== RUN   Test
PASS: chronicle_test.go:41: ChronicleSuite.TestPushPull 8.545s
OK: 1 passed
--- PASS: Test (8.55s)
PASS
  • Manual
  • Unit test
  • E2E

@depohmel depohmel merged commit e2a5df3 into master Aug 22, 2019
@depohmel depohmel deleted the fix-chron-pull-test branch August 22, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants