Helper method to bound an ActionSet's "action type" to a fixed set for Prometheus Metrics #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
mellon-collie
force-pushed
the
kanister-prometheus-metrics-resolution
branch
from
0d23528
to
743d6ab
Compare
pavannd1
reviewed
Aug 18, 2023
mellon-collie
force-pushed
the
kanister-prometheus-metrics-resolution
branch
from
f365d37
to
023af87
Compare
|
will fix the commit history post #2247 merge |
Base automatically changed from
kanister-prometheus-metrics-resolution
to
master
August 25, 2023 01:02
mellon-collie
force-pushed
the
kanister-prometheus-metric-action-type-helper
branch
from
5d481d9
to
dbc048a
Compare
mellon-collie
changed the title
pavannd1
reviewed
Aug 25, 2023
pavannd1
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The PR introduces a simple helper method to bound an ActionSet's "action type" to a fixed set for Prometheus Metrics and avoid cardinality explosions in the Prometheus server. This PR is a WIP until we finalize the inputs we receive from adopters and downstream projects with regards to the set of action types passed.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Added a new table driven test called:
TestGetActionTypeBucketwhich tests different mappings.