-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper method to bound an ActionSet's "action type" to a fixed set for Prometheus Metrics #2256
Helper method to bound an ActionSet's "action type" to a fixed set for Prometheus Metrics #2256
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
0d23528
to
743d6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase whenever possible
f365d37
to
023af87
Compare
will fix the commit history post #2247 merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reposting after rebase
5d481d9
to
dbc048a
Compare
Change Overview
The PR introduces a simple helper method to bound an ActionSet's "action type" to a fixed set for Prometheus Metrics and avoid cardinality explosions in the Prometheus server. This PR is a WIP until we finalize the inputs we receive from adopters and downstream projects with regards to the set of action types passed.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Added a new table driven test called:
TestGetActionTypeBucket
which tests different mappings.