Update ScaleWorkload to provide replicas as string & int value #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdmanv
reviewed
Aug 23, 2019
pkg/function/scale_workload.go
Outdated
| if err != nil { | ||
| return namespace, kind, name, replicas, err | ||
| } | ||
|
|
||
| if val, ok := rep.(int); ok { |
There was a problem hiding this comment.
please use a type switch here: https://tour.golang.org/methods/16
pkg/function/scale_workload.go
Outdated
| if val, ok := rep.(int); ok { | ||
| replicas = int32(val) | ||
| } else if val, ok := rep.(string); ok { | ||
| strToInt := intstr.Parse(val) |
There was a problem hiding this comment.
let's just use https://golang.org/pkg/strconv/#Atoi
pkg/function/scale_workload.go
Outdated
| strToInt := intstr.Parse(val) | ||
| replicas = strToInt.IntVal | ||
| } else { | ||
| return namespace, kind, name, replicas, errors.Wrapf(err, "Failed to decode arg `%s`", ScaleWorkloadReplicas) |
There was a problem hiding this comment.
typically I'd use a naked return with named return values.
Suggested change
| return namespace, kind, name, replicas, errors.Wrapf(err, "Failed to decode arg `%s`", ScaleWorkloadReplicas) | |
| err = errors.Errorf("Invalid arg type %T for Arg %s ", rep, ScaleWorkloadReplicas) | |
| return |
| @@ -269,7 +269,7 @@ func (s *ScaleSuite) TestGetArgs(c *C) { | |||
| }, | |||
| }, | |||
| args: map[string]interface{}{ | |||
| ScaleWorkloadReplicas: 2, | |||
| ScaleWorkloadReplicas: "2", | |||
There was a problem hiding this comment.
Let's leave one of these an int to test both codepaths
There was a problem hiding this comment.
@tdmanv we do have two of these as int.
tdmanv
approved these changes
Aug 23, 2019
pavannd1
approved these changes
Aug 23, 2019
| if err != nil { | ||
| return namespace, kind, name, replicas, err | ||
| } | ||
|
|
||
| var val int |
There was a problem hiding this comment.
[minor] Should this be a function? Okay to be done as an enhancement later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
ScaleWorkload only allowed static int values for
replicasparameter. With these changes, we can provide string values toreplicasin addition to int, kanister will take care of conversion.Pull request type
Please check the type of change your PR introduces:
Test Plan