Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override kanister-tools image in repo controller #2261

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

pavannd1
Copy link
Contributor

Change Overview

  • Add helpers to get kanister-tools image if set from env
  • Add ability to set env in helm chart
  • Use the utility added above
  • Fix repo controller tests
  • Modify existing functions to use the new utility

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
=== RUN   Test
START: repositoryserver_controller_test.go:71: RepoServerControllerSuite.SetUpSuite
PASS: repositoryserver_controller_test.go:71: RepoServerControllerSuite.SetUpSuite	8.814s

START: repositoryserver_controller_test.go:317: RepoServerControllerSuite.TestInvalidRepositoryPassword
PASS: repositoryserver_controller_test.go:317: RepoServerControllerSuite.TestInvalidRepositoryPassword	43.223s

START: repositoryserver_controller_test.go:521: RepoServerControllerSuite.TearDownSuite
PASS: repositoryserver_controller_test.go:521: RepoServerControllerSuite.TearDownSuite	0.061s

OK: 1 passed
--- PASS: Test (52.10s)
PASS
ok  	github.com/kanisterio/kanister/pkg/controllers/repositoryserver	54.022s
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 11, 2023
Kanister automation moved this from In Progress to Reviewer approved Aug 11, 2023
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Aug 11, 2023
@mergify mergify bot merged commit 5a8a687 into master Aug 11, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Aug 11, 2023
@mergify mergify bot deleted the longterm branch August 11, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Repository Server tests use released version of kanister-tools image
3 participants