Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Kanister Prometheus metrics skeleton framework (#2163… #2265

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

mellon-collie
Copy link
Contributor

…)" (#2262)"

This reverts commit dd714ba.

Change Overview

Re-adding the prometheus skeleton changes after it was reverted due to a go.mod failure.

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

N/A

Test Plan

N/A

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 11, 2023
Kanister automation moved this from In Progress to Reviewer approved Aug 11, 2023
@mergify mergify bot merged commit c1e4639 into master Aug 11, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Aug 11, 2023
@mergify mergify bot deleted the kanister-prometheus-skeleton-post-revert branch August 11, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants