Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests for Profile datamover #2266

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Add Tests for Profile datamover #2266

merged 3 commits into from
Aug 16, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Aug 14, 2023 •
edited

Change Overview

Add Tests for Profile datamover

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Manual Testing

$ cd pkg/datamover
$ export AWS_ACCESS_KEY_ID="<aws access key id>"
$ export AWS_SECRET_ACCESS_KEY="<aws secret access key>"
$ go test

OK: 1 passed
PASS
ok      github.com/kanisterio/kanister/pkg/datamover    10.950s

@r4rajat
Add Tests for Profile datamover
8b43f0f 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 14, 2023
PrasadG193
PrasadG193 approved these changes Aug 16, 2023
View reviewed changes
pkg/datamover/profile_test.go
func (ps *ProfileSuite) TestLocationOperationsForProfileDataMover(c *C) {
p := testutil.ObjectStoreProfileOrSkip(c, objectstore.ProviderTypeS3, *ps.location)
dir := c.MkDir()
path := filepath.Join(dir, "test-object1.txt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The filename can be declared as const

pkg/datamover/profile_test.go
err = locationPush(ps.ctx, p, path, source)
c.Assert(err, IsNil)

path = filepath.Join(dir, "test-object2.txt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Kanister automation moved this from In Progress to Reviewer approved Aug 16, 2023
@r4rajat r4rajat added the kueue label Aug 16, 2023
@mergify mergify bot merged commit db68f6f into master Aug 16, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Aug 16, 2023
@mergify mergify bot deleted the add-test-for-profile-datamover branch August 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@kale-amruta kale-amruta Awaiting requested review from kale-amruta

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees

@PrasadG193 PrasadG193

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r4rajat @PrasadG193