Do not create build artifacts in GOOS directory #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depohmel
approved these changes
Aug 23, 2019
|
Hold off on merging - I want to make sure I understand why this was there to start with. |
Should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Mapping
"$(PWD)/bin/$(ARCH)/$$(go env GOOS)_$(ARCH)to ->/go/bininside thebuild container would result in artifacts being placed under
bin/amd64/darwin_amd64when building on OS X - which is not correct since these are not OS X executables
This also broke
make deployandmake release-containercommandsPull request type
Please check the type of change your PR introduces:
Test Plan