Improve repository server controller tests #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
kale-amruta
requested review from
viveksinghggits
and removed request for
PrasadG193
viveksinghggits
approved these changes
Sep 6, 2023
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
kale-amruta
force-pushed
the
improveRepositoryServerTests
branch
from
1041553
to
597bea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Repository Server Controller test are failing intermittently.
Possible reason for intermittent failure could be, default maximum reconcilations that can be run at a time is 1. Hence if there are any failures in setting up the repository server for 1 CR, the controller will keep requeing the requests till the server is ready. This can in turn delay processing of other CRs that that are created.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan