Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NewExecError function #2272

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Introduce NewExecError function #2272

merged 2 commits into from
Aug 22, 2023

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Aug 17, 2023

Change Overview

Introducing NewExecError function which is needed to use in tests outside of kube namespace.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

PrasadG193
PrasadG193 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-sumin e-sumin added the kueue label Aug 22, 2023
@mergify mergify bot merged commit f4aabaf into master Aug 22, 2023
14 checks passed
@mergify mergify bot deleted the new-exec-error branch August 22, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisvmedia denisvmedia denisvmedia approved these changes

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-sumin @denisvmedia @PrasadG193