Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SanitizeTags to stable CreateFromSource #2273

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Add SanitizeTags to stable CreateFromSource #2273

merged 8 commits into from
Nov 22, 2023

Conversation

AKhoria
Copy link
Contributor

@AKhoria AKhoria commented Aug 17, 2023

Change Overview

Add SanitizeTags to stable CreateFromSource

  • Unit test which checks that we are able to obtain a created snapshot through List with tags

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 17, 2023
@AKhoria AKhoria force-pushed the stable-create-from-source-tags-fix branch from eecdced to e783b35 Compare August 17, 2023 13:38
@github-actions GitHub Actions
Copy link

This PR is marked as stale due to inactivity. Add a new comment to reactivate it.

@github-actions github-actions bot added the stale label Nov 16, 2023
Kanister automation moved this from In Progress to Reviewer approved Nov 16, 2023
@pavannd1 pavannd1 removed the stale label Nov 16, 2023
pavannd1
pavannd1 reviewed Nov 16, 2023
View reviewed changes
pkg/kube/snapshot/snapshot_stable.go Outdated Show resolved Hide resolved
pkg/kube/snapshot/snapshot_test.go Outdated Show resolved Hide resolved
pkg/kube/snapshot/snapshot_test.go Outdated Show resolved Hide resolved
AKhoria and others added 3 commits November 20, 2023 12:26
@AKhoria @pavannd1
Update pkg/kube/snapshot/snapshot_stable.go
2f6dfb6 
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
@AKhoria @pavannd1
Update pkg/kube/snapshot/snapshot_test.go
144aaa4 
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
@AKhoria @pavannd1
Update pkg/kube/snapshot/snapshot_test.go
92b0481 
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
@AKhoria AKhoria added the kueue label Nov 20, 2023
@mergify mergify bot merged commit 4de2782 into master Nov 22, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Nov 22, 2023
@mergify mergify bot deleted the stable-create-from-source-tags-fix branch November 22, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 left review comments

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AKhoria @pavannd1 @viveksinghggits