Use postgres DB while connecting to RDS during restore #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
akankshakumari393
approved these changes
Aug 22, 2023
| @@ -23,6 +23,8 @@ import ( | |||
| _ "github.com/lib/pq" | |||
| ) | |||
|
|
|||
| const DefaultConnectDatabase = "postgres" | |||
There was a problem hiding this comment.
Suggested change
| const DefaultConnectDatabase = "postgres" | |
| const defaultConnectDatabase = "postgres" |
There was a problem hiding this comment.
We need to export the const as it is being imported and used in another package.
viveksinghggits
approved these changes
Aug 22, 2023
PrasadG193
commented
Aug 22, 2023
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
During RDS restore, it needs a database to make the connection.
This PR removes overhead of listing all the DBs from the postgres to use one. Instead use default database ie postgres always during restore.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Tested RDS backup restore using rds-postgres-dump-blueprint BP manually as well as by running the integration tests.