Extract PodControllerProcessor interface and default implementation #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-sumin
requested review from
pavannd1,
PrasadG193,
viveksinghggits and
chaitalisg
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
e-sumin
force-pushed
the
simplify-pod-controller
branch
from
40f7456
to
c2039ae
Compare
e-sumin
force-pushed
the
simplify-pod-controller
branch
from
c2039ae
to
5ea1853
Compare
|
@e-sumin I'll be reviewing this by the end of this week. |
denisvmedia
reviewed
Sep 11, 2023
pavannd1
reviewed
Sep 13, 2023
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
pavannd1
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Since there were difficulties with understanding the role of PodControllerProcessor interface, it was moved to a separate entity, including the default implementation.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan