Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of PodController and relating interfaces #2298

Merged
merged 9 commits into from
Sep 14, 2023

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Sep 1, 2023

Change Overview

Improved documentation for PodController and related interfaces.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 1, 2023
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions. Looks good otherwise.

pkg/kube/pod_controller.go Outdated Show resolved Hide resolved
pkg/kube/pod_controller.go Outdated Show resolved Hide resolved
pkg/kube/pod_controller.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Sep 13, 2023
e-sumin and others added 2 commits September 13, 2023 10:09
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
@e-sumin
Copy link
Contributor Author

e-sumin commented Sep 13, 2023

Thank you, suggestions were accepted.

Base automatically changed from simplify-pod-controller to master September 14, 2023 07:50
@e-sumin e-sumin added the kueue label Sep 14, 2023
e-sumin and others added 2 commits September 14, 2023 09:59
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
@mergify mergify bot merged commit d847e11 into master Sep 14, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Sep 14, 2023
@mergify mergify bot deleted the improve_pod_controller_doc branch September 14, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants