Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate VolumeSnapshotClass DeletionPolicy into static VolumeSnapshotContent #232

Merged
merged 7 commits into from
Aug 27, 2019
Merged

Propagate VolumeSnapshotClass DeletionPolicy into static VolumeSnapshotContent #232

merged 7 commits into from
Aug 27, 2019

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Aug 23, 2019 •
edited

Change Overview

Statically provisioned VolumeSnapshotContents have Retain as default deletion policy.

  • Propagate VolumeSnapshotClass.DeletionPolicy into VolumeSnapshotContent
  • This will enable running CSI operations on test clusters where we can control the lifecycle of the snapshots and contents.

Pull request type

Please check the type of change your PR introduces:

  • Feature

Test Plan

  • Manual
  • Unit test
=== RUN   Test
START: snapshot_test.go:51: SnapshotTestSuite.SetUpSuite
PASS: snapshot_test.go:51: SnapshotTestSuite.SetUpSuite	0.417s

START: snapshot_test.go:138: SnapshotTestSuite.TestVolumeSnapshotCloneFake
PASS: snapshot_test.go:138: SnapshotTestSuite.TestVolumeSnapshotCloneFake	0.001s

START: snapshot_test.go:96: SnapshotTestSuite.TearDownSuite
PASS: snapshot_test.go:96: SnapshotTestSuite.TearDownSuite	0.230s

OK: 1 passed
--- PASS: Test (0.65s)

@pavannd1 pavannd1 changed the title [Test] Propagate VSC.Deletion policy Propagate VolumeSnapshotClass DeletionPolicy into static VolumeSnapshotContent Aug 26, 2019
@pavannd1 pavannd1 marked this pull request as ready for review August 26, 2019 22:54
hakanmemisoglu
hakanmemisoglu approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@hakanmemisoglu hakanmemisoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 merged commit 67b40f4 into master Aug 27, 2019
@pavannd1 pavannd1 deleted the test_csi branch August 27, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakanmemisoglu hakanmemisoglu hakanmemisoglu approved these changes

@tdmanv tdmanv Awaiting requested review from tdmanv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @hakanmemisoglu