Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repositoryserver controller Immutability test #2330

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Sep 13, 2023

Change Overview

The TestRepositoryServerImmutability has been failing intermittently with the error:

[2023-09-13T04:22:59.619Z]           `Operation cannot be fulfilled on repositoryservers.cr.kanister.io "test-kopia-repo-server-nb6kj": the object has been modified; please apply your changes to the latest version and try again`
[2023-09-13T04:22:59.619Z]         want:
[2023-09-13T04:22:59.619Z]           `RepositoryServer.cr.kanister.io "test-kopia-repo-server-nb6kj" is invalid: spec.repository.rootPath: Invalid value: "string": Value is immutable`

Since Repository Server Controller keeps on udpating the resource for different operations, resource version for the RepositoryServer Object keeps on changing and can result in above error. Since our goal is to test immutability for the field, this PR changes the update operation to patch operation so that we dont get above issue

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 13, 2023
Kanister automation moved this from In Progress to Reviewer approved Sep 13, 2023
@mergify mergify bot merged commit 2e378a6 into master Sep 13, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Sep 13, 2023
@mergify mergify bot deleted the ImmutabilityTest branch September 13, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants