Fix failure due to changes done on ScaleWorkload replicas type #236
Conversation
SupriyaKasten
changed the title
| case int32: | ||
| val = int(rep.(int32)) | ||
| case int64: | ||
| val = int(rep.(int64)) |
There was a problem hiding this comment.
@SupriyaKasten Quick question. Was the failure caused by going into the default statement?
There was a problem hiding this comment.
Yes @julio-lopez
There was a problem hiding this comment.
Invalid arg type int64 for Arg replicas
| @@ -269,7 +269,7 @@ func (s *ScaleSuite) TestGetArgs(c *C) { | |||
| }, | |||
| }, | |||
| args: map[string]interface{}{ | |||
| ScaleWorkloadReplicas: "2", | |||
There was a problem hiding this comment.
This is removing the case for when the input is specified as a string, no? Shouldn't another test case be added instead? or where is this covered?
There was a problem hiding this comment.
So we do have one unit test that covers string input as well.
There was a problem hiding this comment.
OK, I see it above, got it. Thanks.
There was a problem hiding this comment.
let's use the assignment option in the typeswitch. that we you don't need to re-typecast in each case: https://tour.golang.org/methods/16
Should we merge and refactor in a followup? |
|
Sure! |
Change Overview
This PR fixes the e2e test failure:
Pull request type
Please check the type of change your PR introduces:
Test Plan