Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go version to 1.21 #2392

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Update go version to 1.21 #2392

merged 5 commits into from
Oct 17, 2023

Conversation

mabhi
Copy link
Contributor

@mabhi mabhi commented Oct 11, 2023 •
edited

Change Overview

This PR switches to using golang 1.21-bullseye (stable).

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

Build image logs: https://github.com/kanisterio/kanister/actions/runs/6491734714/job/17629476802

Run docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09
GitHub Actions runtime token ACs
Docker info
Proxy configuration
Buildx version
....
....
Metadata
  {
    "containerimage.descriptor": {
      "mediaType": "application/vnd.oci.image.index.v1+json",
      "digest": "sha256:31e73cccd7c9debdae7f7c127aaf57694f3780fe087fe2119911e52850fcb3f6",
      "size": 856
    },
    "containerimage.digest": "sha256:31e73cccd7c9debdae7f7c127aaf57694f3780fe087fe2119911e52850fcb3f6",
    "image.name": "ghcr.io/kanisterio/build:bump-go-version-1-21,ghcr.io/kanisterio/build:2023.10.12-0540,ghcr.io/kanisterio/build:v0.0.25,ghcr.io/kanisterio/build:sha-452d015"
  }

abhijeet@abhijit-mukherjee ~/Documents/mydev/veeam/kanister (bump-go-version-1-21)$ make shell
launching a shell in the containerized build environment
Running build container in interactive shell mode...
root@abhijit-mukherjee:/go/src/github.com/kanisterio/kanister# go version
go version go1.21.3 linux/amd64
root@abhijit-mukherjee:/go/src/github.com/kanisterio/kanister# golangci-lint version
golangci-lint has version v1.51.2 built from 3e8facb4 on 2023-02-19T22:04:30Z
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Oct 11, 2023
@mabhi
Updated go version
cefa94b 
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
@mabhi
Update kanister image version
6a394fa 
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
@mabhi
Update golangci linter version
ae94569 
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
@mabhi
Removed deprecated go flag (-i)
44f57a2 
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
@mabhi mabhi marked this pull request as ready for review October 12, 2023 11:07
@PrasadG193 PrasadG193 changed the title Updated go version Update go version to 1.21 Oct 12, 2023
PrasadG193
PrasadG193 reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add build image logs and the test plan.
Thanks

docker/build/Dockerfile Show resolved Hide resolved
@pavannd1
Copy link
Contributor

We might have to run make codegen once

@mabhi
Copy link
Contributor Author

mabhi commented Oct 13, 2023

We might have to run make codegen once

Ran codegen as suggested. No changes reported apart from comments about replacing Copyright 2023 The Kanister Authors. to Copyright 2023 The Kubernetes Authors in the autogenerated files. Hence ignored.

pavannd1
pavannd1 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let's create an issue for linter upgrade and merge this.

Kanister automation moved this from In Progress to Reviewer approved Oct 17, 2023
@mabhi mabhi added the kueue label Oct 17, 2023
@mergify mergify bot merged commit bf89e76 into master Oct 17, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Oct 17, 2023
@mergify mergify bot deleted the bump-go-version-1-21 branch October 17, 2023 08:51
leuyentran pushed a commit that referenced this pull request Oct 18, 2023
@mabhi @mergify
Update go version to 1.21 (#2392)
c75ae88 
* Updated go version

Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>

* Update kanister image version

Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>

* Update golangci linter version

Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>

* Removed deprecated go flag (-i)

Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>

---------

Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mabhi @pavannd1 @PrasadG193