-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version to 1.21 #2392
Conversation
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
452d015
to
ae94569
Compare
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add build image logs and the test plan.
Thanks
We might have to run |
Ran codegen as suggested. No changes reported apart from comments about replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let's create an issue for linter upgrade and merge this.
* Updated go version Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> * Update kanister image version Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> * Update golangci linter version Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> * Removed deprecated go flag (-i) Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> --------- Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Change Overview
This PR switches to using golang 1.21-bullseye (stable).
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Build image logs: https://github.com/kanisterio/kanister/actions/runs/6491734714/job/17629476802