Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused DescribeBackups function and related code #2401

Merged
merged 4 commits into from
Oct 15, 2023
Merged

Remove unused DescribeBackups function and related code #2401

merged 4 commits into from
Oct 15, 2023

Conversation

pavannd1
Copy link
Contributor

Change Overview

This PR removes:

  • DescribeBackups function
  • Related unit tests and constants
  • Documentation

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Oct 14, 2023
DeepikaDixit
DeepikaDixit approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@DeepikaDixit DeepikaDixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Oct 14, 2023
@pavannd1 pavannd1 added the kueue label Oct 15, 2023
@mergify mergify bot merged commit 2167aef into master Oct 15, 2023
15 checks passed
Kanister automation moved this from Reviewer approved to Done Oct 15, 2023
@mergify mergify bot deleted the remove-describe-bkp-test branch October 15, 2023 19:47
leuyentran pushed a commit that referenced this pull request Oct 18, 2023
@pavannd1
Remove unused DescribeBackups function and related code (#2401)
584744b 
* Remove unused DescribeBackups function

* Remove related tests

* Remove related docs

* Use a different constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepikaDixit DeepikaDixit DeepikaDixit approved these changes

@chaitalisg chaitalisg Awaiting requested review from chaitalisg

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Remove unused DescribeBackups Kanister Function
2 participants
@pavannd1 @DeepikaDixit